Skip to content

If sync misssed upstream sync being reopened we don't reopen sync from manual update #1632

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
jgraham opened this issue Nov 30, 2022 · 0 comments
Open

If sync misssed upstream sync being reopened we don't reopen sync from manual update #1632

jgraham opened this issue Nov 30, 2022 · 0 comments

Comments

@jgraham
Copy link
Member

jgraham commented Nov 30, 2022

In the case that the GH PR is closed we will run sync.finish(). But if we then reopen the upstream PR, but the bot misses the event for any reason then running wptsync pr doesn't reopen the sync, but instead exits because it's already closed. So we should be able to reopen the sync in this case.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jgraham